GoMap icon indicating copy to clipboard operation
GoMap copied to clipboard

Published 20 hours ago • verified publisher icon bryceco

Improve "better imagery available" check

Open tordans opened this issue 2 years ago • 1 comments

I am using the test flight that has https://github.com/bryceco/GoMap/issues/613#issuecomment-1241380087 for a while, now.

The new dialogue should get additional rules, IMO. Right now it comes up again and again in situations when I really don't need it. In fact, I never clicked 'change', ever, yet.

Possible improvements:

  • Do not show the dialogue whenever I am nearby my user profile home location. We can assume, whatever I am doin't, I am aware of it.
  • Do not show the dialogue whenever I picked a custom image layer. Again, we can assume, I am aware and know what to do.
  • Do not show the dialogue when I have background layers disabled. It is very out of context then, and breaks my train of thought.
  • Show the dialogue only once for one region (like within 100 km of the first lat/lng that was recorded). Once I know, I know. ELI is not always right, especially with the fallbacks "best" (there are many issues on that in the ID and ELI repo about how to improve the "best" logic)

tordans avatar Oct 10 '22 04:10 tordans

Thanks, this is great feedback. Where I'm located there isn't any variation in imagery providers so it's hard to get a feel for what its like in Europe, etc.

bryceco avatar Oct 10 '22 04:10 bryceco

This didn't get fixed in 3.1.8 but it will definitely be in the next release.

bryceco avatar Nov 28 '22 22:11 bryceco

  • Do not show the dialogue whenever I am nearby my user profile home location.

I don't like this idea because new users, who probably are mapping locally, won't get the notification.

  • Do not show the dialogue whenever I picked a custom image layer.

It will now only suggest a "best" imagery if you're currently using a global imagery provider (Bing, Mapbox, Maxar, etc.)

Also, I added code that will automatically switch to the current best imagery (without notification) in the situation that you currently have a non-global layer and then pan to a location that is outside its coverage. Not sure how you feel about that.

  • Do not show the dialogue when I have background layers disabled.

Fixed.

  • Show the dialogue only once for one region (like within 100 km of the first lat/lng that was recorded).

It's currently set to check every 10 km. I think that's a reasonable compromise.

bryceco avatar Dec 10 '22 00:12 bryceco

Sounds good, thank you! I will close this — we can always reopen if something could be adjusted.

tordans avatar Dec 11 '22 08:12 tordans