Replace existing non-matching tags when preset changes

[tordans]

I think the behavior when editing an existing element and changing its preset should be changed.

Right now only Tags in conflict are updated with the new data from the preset. But existing tags that are not part of the preset stay.

This is an issue since those tags are only visible from the all tags panel. So regular preset users would not see them and not look to manually remove them.

Example: changing an area from car parking to bike parking. The car parking tags like parking=street_side ... are still there.

Video: https://share.icloud.com/photos/0qovxefRrSnB0u_G3qp_NRZDw

I think, what iD does is, to remove all but those tags that are present in the preset.

I wonder if for GoMap a user confirmation where a good approach. Ideally not when I change the preset, since this is disruptive to my flow. But maybe as a kind of validation: on the Common Tags Panel, there could be a message saying "this objects has tags that are not part of the recommends preset, please review." And then link the all tags where those tags have an indicator "this tag is not part id the preset. Please review with the wiki if it's a good tag to have here or remove it."

[bryceco]

The behavior should be exactly the same as iD. If it is different than that's definitely a bug, but I think you're incorrect saying that iD removes the non-preset tags. Obviously lots of tags should not be removed in general: addr:*, name, etc.

I'm concerned that warning about non-preset tags would introduce a lot of noise for the user, as there is a long list of tags that can show up unexpectedly: tiger notes, import notes, etc. I think its better to surface those tags on Common Tags somehow so the user knows they exist but don't flag them as an error.

[dieterdreist]

“do not warn about this tag anymore”