node-stream-spigot icon indicating copy to clipboard operation
node-stream-spigot copied to clipboard

Published 20 hours ago • verified publisher icon brycebaril

Tests fail in 0.11

Open brycebaril opened this issue 10 years ago • 3 comments

Investigating...

# tests 12
# pass  1
# fail  11

brycebaril avatar Jan 23 '15 18:01 brycebaril

Changing it to force use of http://npm.im/readable-stream vs core stream.Readable if available fixes the issue but I'd like to investigate what the difference is there.

brycebaril avatar Jan 23 '15 18:01 brycebaril

Ugh, ok this breaks because of this PR. I am not a fan of this change.

https://github.com/joyent/node/pull/7856

brycebaril avatar Jan 23 '15 20:01 brycebaril

Fixed for now by only using readable-stream to avoid inconsistencies in core.

brycebaril avatar Jan 23 '15 20:01 brycebaril