Bartosz Rybacki

Results 75 comments of Bartosz Rybacki

interesting, test fails ``` Tests Suite: [sig-storage] Storage Starting a VirtualMachineInstance [rfe_id:3106][crit:medium][vendor:[email protected]][level:component]With an emptyDisk defined and a specified serial number [test_id:3135]should create a writeable emptyDisk with the specified serial number ...

The more I look at this, I think we need two different ways to build vmi, - set some values (maybe override) using `WithSomething` - add some values, with `AddSomething`...

The default user data is there only for a hack - like in the following code: ``` func NewCirros(opts ...Option) *kvirtv1.VirtualMachineInstance { // Supplied with no user data, Cirros image...

@akrejcir thanks for the PR, This is really a good cleanup! /lgtm

lets see if it works, and the tests are green

> Looks like KubeVirt only imports the [pkg/clone](https://github.com/kubevirt/kubevirt/tree/main/vendor/kubevirt.io/containerized-data-importer) package. Maybe make that module? Does it change anything in dependency tree/analysis when that is a module? If yes then I agree...

@akrejcir this is very good PR, and making a [pkg/clone](https://github.com/kubevirt/kubevirt/tree/main/vendor/kubevirt.io/containerized-data-importer) a module will make it even better. That way managinf dependencies in kubevirt will be easier/cleaner. What is your opinion...

Its own `version` and `tag`. I did not think about this. @mhenriks @awels what do you think?

/reopen this can be actually closed by merging #8513

#8513 was merged, It provides better error message. I think this might be enough to close current issue.