Laravel4-Vagrant icon indicating copy to clipboard operation
Laravel4-Vagrant copied to clipboard

Should composer be part of its own manifest instead of the laravel one?

Open echochamber opened this issue 11 years ago • 5 comments

I really like the look of this vagrant box and am going to use it myself for projects (laravel and other non-laravel ones).

I've never really used puppet before but being it seems like installing laravel and installing composer should be 2 seperate steps (especially considering its a global installation of composer).

So something like puppet/modules/composer/manifests/init.pp

class composer
{

    package { 'git-core':
        ensure => present,
    }

    exec { 'install composer':
        command => 'curl -s https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin',
        require => Package['php5-cli'],
        unless => "[ -f /usr/local/bin/composer ]"
    }

    exec { 'global composer':
        command => "sudo mv /usr/local/bin/composer.phar /usr/local/bin/composer",
        require => Exec['install composer'],
        unless => "[ -f /usr/local/bin/composer ]"
    }
}

I wanted to get others thoughts on this before submitting a PR

echochamber avatar Feb 22 '14 00:02 echochamber

+1

erichgoldman avatar Mar 13 '14 22:03 erichgoldman

This is almost certainly the correct way to do this. Thoughts @bryannielsen ?

SegFaultx64 avatar Mar 13 '14 23:03 SegFaultx64

Yeah this sounds good to me, I can break it out next chance I get or if you want to submit a PR @echochamber I'll merge it in :-)

bryannielsen avatar Mar 15 '14 00:03 bryannielsen

Sure. I'll make a pull request later this weekend. On Mar 14, 2014 5:01 PM, "Bryan Nielsen" [email protected] wrote:

Yeah this sounds good to me, I can break it out next chance I get or if you want to submit a PR @echochamber https://github.com/echochamberI'll merge it in :-)

Reply to this email directly or view it on GitHubhttps://github.com/bryannielsen/Laravel4-Vagrant/issues/54#issuecomment-37709013 .

echochamber avatar Mar 15 '14 00:03 echochamber

@bryannielsen Just made the pull request here.

echochamber avatar Mar 17 '14 01:03 echochamber