after-dark-css icon indicating copy to clipboard operation
after-dark-css copied to clipboard

Published 20 hours ago • verified publisher icon bryanbraun

Messages - Improve behavior on mobile

Open bryanbraun opened this issue 4 years ago • 3 comments
trafficstars

I saw this error reported by google search console for these urls:

  • [ ] https://www.bryanbraun.com/after-dark-css/all/messages.html
  • [x] https://www.bryanbraun.com/after-dark-css/all/messages2.html

image

Things to improve:

  • Add a mobile metatag and confirm that it makes the text look better on phones.
  • Ensure that the animation for Messages goes all the way across the screen (it seemed like it wasn't scrolling all the way when I checked on it).

bryanbraun avatar Aug 13 '21 02:08 bryanbraun

I would like to work on it. Please assign it to me. (Hacktoberfest)

Manishgupta200 avatar Oct 18 '21 07:10 Manishgupta200

Thanks for assigning

Manishgupta200 avatar Oct 19 '21 06:10 Manishgupta200

Thanks @Manishgupta200, for the fixes on Messages2 (in https://github.com/bryanbraun/after-dark-css/pull/15). That part looks great now!

We could still use some similar fixes on the original Messages. Anyone want to attempt those fixes?

In case it's unclear what Messages is supposed to look like, it' supposed to start offscreen (on the left side of the screen), scroll left onto the screen, and continue scrolling until it is offscreen on the right side of the screen. At that point it moves back offscreen (on the left side of the screen), and repeats scrolling again.

bryanbraun avatar Oct 21 '21 04:10 bryanbraun