django-push icon indicating copy to clipboard operation
django-push copied to clipboard

Fix for adding subscriptions through the django admin

Open dferrante opened this issue 10 years ago • 1 comments

the admin.py for subscriber tries to do a url reverse for subscriber_callback, but the primary key doesn't exist for new subscriber objects, so it errors out. these commits just have it return None if the pk doesn't exist. this shouldn't mess up any existing code, and callback_url isn't called for anything significant until after the object is created, so returning None shouldn't have any side effects. all tests pass. if you think this is all good, please merge and push to pypi at your convenience, thanks!

dferrante avatar Sep 09 '14 16:09 dferrante

Can you add a regression test?

timgraham avatar Jul 12 '16 14:07 timgraham