Bernhard Rusch

Results 170 comments of Bernhard Rusch

@dasraab unfortunately not yet, sorry - we'll let you know as soon as we have a decision. Thanks for your patience. 😊

I'm wondering if using Twig blocks and the template override functionaility of Symfony is a more elegant way, because `{{ contentBelowLogin|raw }}` is not really best practice ... We can...

I'm wondering if that is really a very common use case ... maybe we should keep that configurable, or just provide the functionality in the context menu? Just thinking, because...

Yeah, something like that. Or maybe we could even think about a more generic approach where you can configure the available buttons incl. adding your own buttons (or bundles) -...

I think it should be also possible to use Doctrine's schema manager for that, just as we do it e.g. in our migrations: https://github.com/pimcore/pimcore/blob/2f18a0f26380c56b609d937b40d2050c8d1a3e1a/bundles/CoreBundle/Migrations/Version20210408153226.php#L39

To be honest, even if this could be quite handy, it opens up a security issue. I know, this should be used by privileged users only, but this won't count...

Imho this should be safe and shouldn't have any side-effects. Thanks a lot 👍

@bitfactory-jurgen-jansma thanks a lot for your PR! 2 thinks we should consider as well: 1. We should also use `$inAdmin` argument for `getYoutubeCode()` same as for `getAssetCode()`, see: https://github.com/pimcore/pimcore/blob/b447bc02341a2eb097bc48c2f6e9f3f84d708829/models/Document/Editable/Video.php#L457 2....

Failing Codeception tests are not related to this PR ... caused by #13171 (fix)