Bernhard Rusch

Results 231 comments of Bernhard Rusch

@kingjia90 agree, the installer should tackle this as well and should create all necessary directories👍

@kingjia90 is right, this is not a Pimcore issue, it's by design how Symfony Config works. See also: https://github.com/symfony/symfony/issues/57210#issuecomment-2136844261 (about `enabled:`) and https://github.com/symfony/symfony/issues/57958#issuecomment-2294904662 (about `type` enum). Yes, we can think...

@kingjia90 just created https://github.com/pimcore/pimcore/pull/17850 - I think we should rollback everything if one file move fails, just to be consistent - otherwise it could be very confusing when certain files...

@kingjia90 yeah, I was thinking about non-techies, how should you explain that e.g. only 98% of moving the files actually worked and that you now have to merge the 2...

@kingjia90 I would be also fine with the second option, so not rolling back, but keeping the failed files in their old location, as long as we report this behavior...

@cancan101 > I also just noticed that Pimcore moves all the files in the folder, _not just the Assets that are tracked by Pimcore_. Yes, but those folders should be...

@kingjia90 > I hope it's an extremely rare case and consequence of misusing/bad practice. Yes, I agree, it shouldn't be the normal case. Since this should be an edge-case anyway...

@cancan101 yes, plz create follow-up tickets - thanks! 😊

See also https://github.com/pimcore/pimcore/pull/17398#issuecomment-2250336702 Imho it's mostly about the preview, right?

@cancan101 > Is there any appetite for adding additional asset types to Pimcore? Yeah, PRs are always welcome 😊