JavaFXSmartGraph icon indicating copy to clipboard operation
JavaFXSmartGraph copied to clipboard

Close #23 by adding gradle and gradle based changed to resource loading.

Open madhephaestus opened this issue 2 years ago • 2 comments

In the PR the build.gradle file is added

The way resources are loaded is compatible with source and binary builds from gradle.

Eclipse project files are ignored

madhephaestus avatar Aug 03 '21 14:08 madhephaestus

@madhephaestus Thanks for the PR! :+1:

But if the library is made available through a maven repo, won't this resolve the issue? Several other users are requesting this, but I haven't gotten the time to investigate the proper integration with github packages.

brunomnsilva avatar Aug 06 '21 14:08 brunomnsilva

The github maven hosting requires logins to access, meaning that's only really helpful for builds that take place on github servers. For a general project having a gradle build files allows them to consume this library directly without having to set up github pipelines themselves (which for many projects not hosted on github is basically a blocker)

If you set up hosting on Maven Central (a much more time consuming process to be sure) then gradle would not be necessary.

Hold off on importing this, i have a few changes to the gradle build coming to make it easy to pull into IHMC's build stack, which will also make binary publishing much easier in the future, and might be something my CI will take care of for you ;)

madhephaestus avatar Aug 06 '21 15:08 madhephaestus

Library made available through maven central.

brunomnsilva avatar May 04 '23 22:05 brunomnsilva