Bruno Garcia
Bruno Garcia
> One shot connections + immediate tx broadcast without inv,getdata exchange leaks that the tx is likely being broadcast for the first time (easy to censor the tx as the...
Correct me please if I'm missing anything. Considering: ``` - Once we get an INV from somebody, request the transaction with GETDATA, as if we didn't have it before. -...
cc: @furszy @theStack
> Could also add a test framework option to whitelist peers. So we don't have to add -whitelist flag everywhere. Sounds good! Gonna implement it!
force-pushed: Added `self.whitelist_peers` in `test_framework` to avoid having to add `-whitelist` flag everywhere. Also, I changed the 1st commit message as suggested by @stratospher.
Force-pushed addressing @jonatack's review. - Moved `InitializePermissionFlags` out of `CConnman` - Made `TryParsePermissionFlags` static - Added more test coverage https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1186367052 - Improved documentation
Force pushed addressing: - https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1191183121 - https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1191191757 - https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1191197012 - https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1191201370
> The InitializePermissionFlags function is added twice, at two different locations, at the first and second commits, then one of them gets erased at the third one. Would be good...
Force-pushed: 1. Renamed `whitelist_peers` to `noban_tx_relay` and set up it `True` for tests that explicity was whitelisting peers with this purpose of speeding up. - https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1274667131 2. Added test coverage...