Bruno Garcia
Bruno Garcia
I had to touch `bench` code to fix an error CI pointed out, so I took the moment to address some suggestions from @stickies-v. Addressed: https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153145784 https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153157545 https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153170805
@stickies-v I'm addressing them at this moment, will push soon.
Force-pushed addressing: - https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1201199915 - https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1177587552 Maybe done with nits, and we can have it merged?
> @brunoerg? Sounds good to me. I didn't check the code yet but is the CJDNS address from `ConsumeNetAddr` always valid?
Concept ACK
> Another one: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64593 cc @brunoerg I don't have access to see it in depth 🙁. I suppose it might be related to the descriptor parse. I think we can...
> The "Reproducer Testcase" should be public. "Access denied" when I try to access it.
Nice one!