Bruno Garcia

Results 211 comments of Bruno Garcia

> Coverage is nice, but if the fuzz test never finds any real user-facing issues, it will be useless. I don't think any wallet fuzz target found a real issue...

Just added https://github.com/bitcoin/bitcoin/pull/29936 to the list. It's a regression to #27271.

Added https://github.com/bitcoin/bitcoin/pull/30134 to the list for review. It adds more coverage for `ScriptPubKeyMan`. edit: merged

Thanks, @tdb3 for reviewing it. Just changed it to keep the ban/unban of an onion addresses and moved the test persistence across node restart to `p2p_disconnect_ban`.

Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/29688#discussion_r1536966972 and https://github.com/bitcoin/bitcoin/pull/29688#discussion_r1536968199

Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/29688#discussion_r1538456073

> It seems like these two tests primarily revolve around the `setban` RPC and do a couple of the same things, so perhaps they can be consolidated into one test?...

> Actually, I'm kind of confused about the state of the software here I feel the same haha. Seems like this project is the best fit to move asmap stuff...