Bruno Garcia
Bruno Garcia
> Regarding the name, I prefer avoiding negations in variable, option or parameter names. What do you think about `avoid_change` or `prefer_changeless`? `avoid_change` is really good, I will adopt it....
Force-pushed rebasing and addressing `avoid_change` as suggested by @Xekyo
Thanks, @Xekyo! > What will users think they're opting into when they activate an avoid_change or prefer_changeless option? I see two scenarios: Using `avoid_change` users would be saying: "Please, don't...
@JeremyRubin Is there a specific reason to use `tornado`, instead of using `flask ` or any other alternative?
> tornado is async / non blocking and so it should be simpler to use Tornado to e.g. extend the script to work with a pool of nodes that respond...
@rafaelpac It's everything right! From a key you can generate MANY addresses. You are assuming it should return always the same address, but it is not true. Reuse addresses is...
Concept ACK
Concept ACK Should we consider the manual block-relay-only connections as anchors? E.g I added 2 manual block-relay-only connections in addition to the 2 outbound block-relay-only ones and I'd like to...
Addressed @jonatack's review and now it returns `std::optional`.
Force-pushed to make `LookupSubnet` not return an invalid but existing `CSubNet`, now it returns a valid `CSubNet` or `std::nullopt`. Thanks, @luke-jr and @mzumsande.