Bruno Garcia

Results 211 comments of Bruno Garcia

Force-pushed addressing: https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1490381331 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1490757436 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1490780583 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1490807334 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1490770478 Thanks @vasild and @amitiuttarwar for reviewing!

> About the graph in the OP: "... until it finds an address from a network that compose 20% ...". The chance of not getting the result after N tries...

> If this is correct and can be reproduced by others, I think that something should be done about it. If this PR would increase performance for a rare and...

@mzumsande you're right! I checked the performance goes down when calling `Select` when addrman only has addrs for reachable nets. So, I changed the approach to call `Select` with networks...

Force-pushed addressing: https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503982139 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503704858 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503683117 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503675942 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503672316 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503668606 https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1503659916 I changed the approach to know verify new and tried table isolated, so if there is less than 50% of reachable...

Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/29436#discussion_r1504723525.

Force-pushed simplifying the approach. I changed the last argument of Select() to be a `const` ref and now we just call `Select` with reachable networks since it does not significantly...

> I would use this script instead of my hacky bash script, if there were a way of running just n random fuzz targets instead of all of them like...