Bruno Garcia

Force-pushed changing the code to make it faster. Removed the `assert_debug_log` when adding an address into addrman. Thanks, @fjahr.

Rebased and since `addpeeraddress` is now reliable (#28998), we can use its return to count the entries.

I agree with @mzumsande. Also, I'm not sure but I do believe you could use tracepoints to track it. See: https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md

cc: @mzumsande

@naumenkogs and @amitiuttarwar I just updated the description with more infos. Thanks! -------- > Or, what i think is even more likely, we may rather change Addrman architecture to facilitate...

> What about setting preferred_net Yes, I previously discussed this options with @mzumsande. It might be an alternative, sure. > That would skew the outcome though. If addrman has 60%...

I'll close this PR to work on a "less aggressive" approach (extending `Select` to support multiple networks). I will provide my benchmarks on that new PR. Thanks, @vasild @mzumsande @naumenkogs...

``` test 2024-02-07T08:26:22.085000Z TestFramework (ERROR): JSONRPC error Traceback (most recent call last): File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main self.run_test() File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_bumpfee.py", line 100, in run_test test_watchonly_psbt(self, peer_node, rbf_node, dest_address) File...

crACK dddd7be9bf038c25f3e53c5bd708fb9cf73d4493

cc: @vasild @naumenkogs @amitiuttarwar @mzumsande