Bruno Garcia
Bruno Garcia
```sh "network" : "str", (string) The network (ipv4, ipv6, onion, i2p, cjdns) ``` Instead of being a string, wouldn't make sense it to be an array? E.g. I want to...
> Since there doesn't seem to be very much review interest... is there any benefit in moving these tests to a different file? Currently, there are stuff that are being...
that was just a question, thinking about complexity I agree on leaving it as is. going to review in depth soon.
I'll close for now and work in a simpler alternative.
I agree on having test coverage for it with a network arg, something like: ```diff diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 3d39fb47d..6928c1211 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -331,11 +331,23 @@...
perhaps we could also check this is a hidden RPC like `addpeerinfo`? ```py self.log.debug("Test that addpeerinfo is a hidden RPC") # It is hidden from general help, but its detailed...
I use `all-lint.py` frequently, it's convenient even not running all lints de facto. However, since there is other way to achieve the same and it's documentated, Concept ACK on removing...