Bruno Garcia
Bruno Garcia
> @achow101 any thoughts on having HWI catch this cryptic 0x6982 status code and throw a more clear error (that we can then just pass on to the user)? Not...
> @brunoerg most likely yes, but I can't find a full list anywhere. Me either. I've some of them but I manually mapped. ----------- edit: I found them in HWI:...
ACK 4357158c4712d479522d5cd441ad4dd1693fdd05 I did same test as https://github.com/bitcoin/bitcoin/pull/24313#issuecomment-1867691764 but with the latest version of HWI. ```sh ./src/bitcoin-cli -rpcwallet=ledger7 walletdisplayaddress "bc1qfshzjl770c6qz560cade6ynswj2a3scqzm4a4m" error code: -1 error message: '/Users/brunogarcia/projects/HWI/hwi.py' error: Could not open...
Concept ACK
From lint: ```diff + test/lint/all-lint.py This diff appears to have added new lines with trailing whitespace. The following changes were suspected: diff --git a/src/wallet/test/fuzz/spend.cpp b/src/wallet/test/fuzz/spend.cpp @@ -0,0 +1,254 @@ +namespace...
CI failure is unrelated to this PR.
friendly ping: @dergoegge
Thanks, @dergoegge for your review. Force-pushed addressing: https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442764742 and https://github.com/bitcoin/bitcoin/pull/29172#discussion_r1442763249.
> New compiler warning, using gcc 13.2.1 I'm checking it atm.
Concept ACK