Bruno Garcia
Bruno Garcia
Force-pushed addressing: https://github.com/bitcoin/bitcoin/pull/28928#discussion_r1517181164 https://github.com/bitcoin/bitcoin/pull/28928#discussion_r1518567175 https://github.com/bitcoin/bitcoin/pull/28928#discussion_r1518567404 https://github.com/bitcoin/bitcoin/pull/28928#discussion_r1518567594
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/28928/files#r1518662935 and changed the order of the commits to simplify the changes. Thanks, @furszy.
CI failure is unrelated.
Force-pushed removing the commit with the speed-up due to @achow101's review (see https://github.com/bitcoin/bitcoin/pull/28928#discussion_r1521530033). I left the coverage addition for bech32 which will be simpler to review.
> Feels like this could be confused with real/beancounter accounts like we used to support years ago. Maybe hd_account or something? I agree, had same thought. Just changed in latest...
> I think this might be a better candidate for a createwalletdescriptor (https://github.com/bitcoin/bitcoin/pull/29130) equivalent for external signers rather than continuing to jam more arguments into createwallet. You mean have a...
> Also agree very much with luke-jr that it would be good not to allow this option to be passed by position, and instead to add an OBJ_NAMED_PARAMS options parameter...
Closing for now.
I tested it with HWI and Ledger Nano S Plus. -------- - I created a wallet: ```sh ./src/bitcoin-cli -named createwallet wallet_name=ledger3 disable_private_keys=true descriptors=true external_signer=true` ``` - Got a new address:...