Bruno Garcia
Bruno Garcia
rebased and fixed issue pointed out by CI
> Tested it with bitcoin-qt and I'm wondering if later as a follow-up we could add a feature as a "nice to have" to identify the "whitelisted" peers (and it...
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1411359535
Force-pushed: Rebased and addressed https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1365833858 and https://github.com/bitcoin/bitcoin/pull/27114#discussion_r1440760716 (I moved the `-whitelistrelay` and `-whitelistforcerelay` verification to the `AddWhitelistPermissionFlags` function.
> Could squash this easy change into one commit? Sure, done!
> we should probably rewrite this test using only one node, and multiple wallets, instead of five different nodes. sgtm, perhaps 2 nodes? why only one? Also, I have no...
> This can be tested by loading and unloading wallets instead of restarting nodes (this was a restriction from the past, prev to introducing multi-wallets support). No extra nodes nor...
Good idea, @furszy. master: 1.78s user 0.57s system 28% cpu 8.157 total this PR: 0.76s user 0.20s system 35% cpu 2.668 total