bitcoinfuzz icon indicating copy to clipboard operation
bitcoinfuzz copied to clipboard

clightning: `./configure` not running on macOS

Open brunoerg opened this issue 7 months ago • 2 comments

On mac 14.3 with clang 18, I cannot build clightning module because it's not running ./configure on external/lightning. It seems the Makefile from clightning module is set to do it but somehow is not working?

brunoerg avatar May 22 '25 20:05 brunoerg

cc @erickcestari

brunoerg avatar May 22 '25 20:05 brunoerg

On CI it was called here: https://github.com/bitcoinfuzz/bitcoinfuzz/actions/runs/15191972937/job/42726825044#step:23:14

If config.vars already exists, ./configure won’t run again.

Maybe we can improve the ./configure for MACOS?

$(LIGHTNING_DIR)/config.vars:
    @echo "Running ./configure in $(LIGHTNING_DIR)..."
    @if [ "$(shell uname)" = "Darwin" ]; then \
        cd $(LIGHTNING_DIR) && ./configure --disable-compat --disable-valgrind CC=cc; \
    else \
        cd $(LIGHTNING_DIR) && ./configure --enable-address-sanitizer --disable-compat --enable-fuzzing --disable-valgrind --enable-ub-sanitizer CC=clang; \
    fi

erickcestari avatar May 23 '25 12:05 erickcestari

It seems we could improve (we can concetrate ideas on other issue), but I figured out my issue on it. Closing for now.

brunoerg avatar May 28 '25 16:05 brunoerg