eth-url-parser icon indicating copy to clipboard operation
eth-url-parser copied to clipboard

Published 20 hours ago • verified publisher icon brunobar79

Further Implementation of the EIP-681 spec + Optimizations

Open lucemans opened this issue 2 years ago • 2 comments

For starters, thank you very much for the existence of this package. As a desire to further support more of the features described in EIP-681 in the modern wallet this PR has been made.

Here are some of the changes that this PR includes

  • Introduce typescript aswell as types for input and output.
  • Shrunk Bundle Size from 144kb => 4.4kb
  • Deprecate qs as it does not support multiple parameters with the same name
  • Introduce more documentation
  • Introduce support for custom function names
  • Introduce support for custom (& overlapping) arguments
  • Expand tests to encompas
    • custom function names
    • custom arguments

Things left to do:

  • Update README.md to reflect changes (working on it 😉)

Looking forward to hearing from you!

lucemans avatar May 05 '22 16:05 lucemans

Sweet! I will get around to them as soon as possible!

lucemans avatar May 09 '22 07:05 lucemans

Looks cool!

svemat01 avatar May 14 '22 21:05 svemat01