leaflet.fullscreen icon indicating copy to clipboard operation
leaflet.fullscreen copied to clipboard

doc: Add missing import for Control.FullScreen.css

Open danidee10 opened this issue 1 year ago • 5 comments

Without this import. The svg button is not loaded and yo end up with a "blank button"

danidee10 avatar Nov 05 '24 08:11 danidee10

Any thought on this @BePo65 ?

brunob avatar Nov 05 '24 09:11 brunob

I'll take a look at it on the next weekend - quite busy at the moment :-)

BePo65 avatar Nov 07 '24 06:11 BePo65

Basically we could give some hints on how the "Include Control.FullScreen.css in your page" from the "How?" section can be done in esm based frameworks. But the PR is for react only.

So perhaps it would be better to add a 3rd point, which could look like:

3. Add `leaflet.fullscreen/Control.FullScreen.css` from the node_modules directory to your project. In React you have to import this file and in Angular you have to add './node_modules/leaflet.fullscreen/Control.FullScreen.css' to your angular.json file.

BePo65 avatar Nov 10 '24 09:11 BePo65

@danidee10 could you update your PR as suggested by @BePo65 ?

brunob avatar Nov 12 '24 13:11 brunob

bump @danidee10 or should we close this issue ?

brunob avatar Mar 06 '25 13:03 brunob