php-git-hooks icon indicating copy to clipboard operation
php-git-hooks copied to clipboard

Published 20 hours ago • verified publisher icon bruli

Make ascii art output optional?

Open davidmpaz opened this issue 7 years ago • 8 comments

Hi,

thanks in advance for this project

davidmpaz avatar Mar 12 '17 10:03 davidmpaz

Why I should be it like an option?

bruli avatar Mar 13 '17 05:03 bruli

Hi,

i was referring to be able to configure whether to print it or not. It is a cool ascii, still when committing frequently I found it too much, for my personal taste the message would be enough.

but of course, it is only about personal taste ;) don't want to be a joy killer :)

davidmpaz avatar Mar 13 '17 06:03 davidmpaz

Hi there,

shall we close this issue as "wont fix" ?

davidmpaz avatar May 03 '17 21:05 davidmpaz

Hey, I agree the Ascii art should be optional! :)

itaelle avatar Jun 07 '17 17:06 itaelle

Don't worry. I will do cooming soon.

bruli avatar Jun 10 '17 13:06 bruli

Don't worry. I will do cooming soon.

@bruli Hello) are you going to review this pr https://github.com/bruli/php-git-hooks/pull/129 ? to be honest, I don't like the way I solved this issue. Maybe it will be better to make message printer as a component, make static method non static and add configuration to this component. I think it's bad idea to pass 'enableFaces' param everywhere, but that's the simplest decision i've found... What do you think?

alexgivi avatar Aug 01 '19 12:08 alexgivi

Can we get an answer to this? I really wish the faces were optional.

s2925534 avatar Jul 11 '20 05:07 s2925534

this library is abandoned. don't use it. use phpcs, php-cs-fixer, static analyzers directly.

alexgivi avatar Jul 18 '20 12:07 alexgivi