nppPluginManager icon indicating copy to clipboard operation
nppPluginManager copied to clipboard

Plugins list x32 - web interface - bug when unchecking `Run when Notepad++ is closed`

Open jcaillon opened this issue 6 years ago • 2 comments

Hello,

Thank you for developing nppPluginManager.

Context

I'm facing a problem updating info on my plugin here : https://npppm.bruderste.in/plugins. The plugin is 3P - Progress Programmers Pal, it is developed in C# and previously required .net 4.0. For several reasons i need to now target .net 4.6.2 so i have included a small program to check the current installed version of .net and install an update if needed.

Description of the Issue

I want to "RUN" a program after downloading and copying required files. But each time I add a "run" step, the plugin doesn't save correctly. I basically saves until the run step, and everything after the run is lost. E.G. i put 2 delete in the "remove" section, those are lost when I save with a run step.

I tried uploading an xml but it just doesn't work either :/

[EDIT] the bug only appears if Run when Notepad++ is closed is un-checked

image

Steps to Reproduce the Issue

Add a "run" step and don't check Run when Notepad++ is closed, click "edit plugin" to save it. Edit the plugin again, run step as disappeared.

Expected xml

<?xml version="1.0" encoding="UTF-8"?>
<plugins>
   <plugin name="3P - Progress Programmers Pal">
      <unicodeVersion>1.8.1</unicodeVersion>
      <aliases>
         <alias name="3P" />
      </aliases>
      <description>[Requires .net framework 4.6.2]\n\n3P is a notepad++ plug-in designed to help writing OpenEdge ABL (formerly known as Progress 4GL) code. It provides :\n\n- a powerful auto-completion\n- tool-tips on every words\n- a code explorer to quickly navigate through your code\n- a file explorer to easily access all your sources\n- the ability to run/compile and even PROLINT your source file with an in-line visualization of errors\n- more than 50 options to better suit your needs\n- and so much more!\n\nVisit http://jcaillon.github.io/3P/ for more details on the plugin</description>
      <author>Julien Caillon</author>
      <homepage>http://jcaillon.github.io/3P/</homepage>
      <sourceUrl>https://github.com/jcaillon/3P</sourceUrl>
      <latestUpdate>More infos here :\nhttps://github.com/jcaillon/3P/releases/tag/v1.8.1</latestUpdate>
      <stability>Good</stability>
      <install>
         <unicode>
            <download>https://github.com/jcaillon/3P/releases/download/v1.8.1/3P.zip</download>
            <copy from="3P.dll" to="$PLUGINDIR$\" validate="true" />
            <run file="NetFrameworkChecker.exe" arguments="-ShowOnlyIfNotInstalled" outsideNpp="0" />
         </unicode>
      </install>
      <remove>
         <unicode>
            <delete file="$PLUGINDIR$\3P.dll" />
         </unicode>
      </remove>
   </plugin>
</plugins>

Validation :

"3P - Progress Programmers Pal":
    {
        "94ffc9d97d2c1437a66a5e9312d22d3a": "3P.dll",
        "d303f05a3de2c11d830743a255732411": "NetFrameworkChecker.exe"
    }

jcaillon avatar Mar 05 '18 12:03 jcaillon