nppPluginManager
nppPluginManager copied to clipboard
bruderstein
Plugin manager update loop
Description of the Issue
The plugin manager asks for an update every time I try to install an update.
Steps to Reproduce the Issue
- Open Plugins->Plugin Manager->Show Plugin Manager
- Click on "Install" (no selection of Plugins needed)
- Result: Popup "An update is available to Plugin Manager. It is strongly advised that the Plugin Manger is updated before any other plugin is installed or Updated. Would you like to update the Plugin Manager now?"
- Click on "Yes".
- Restart Notepad++ when it tells you to do it.
- Go to Plugins->Plugin Manger->Show Plugin Manager again
- Click on "Install" again
- Result: The same popup.
In the "Updates" tab there is no update. First there was one for the plugin manager, then I installed that update before installing other plugins, now it's not in the list anymore, but it keeps asking. Plugin manager version is 1.4.3.
Debug Information
Notepad++ v7.3.2 (32-bit) Build time : Feb 12 2017 - 23:15:39 Path : C:\Program Files (x86)\Notepad++\notepad++.exe Admin mode : ON Local Conf mode : OFF OS : Windows 7 (64-bit) Plugins : ComparePlugin.dll CustomizeToolbar.dll MenuIcons.dll NppExternalLexers.dll NppSaveAsAdmin.dll PluginManager.dll RunMe.dll SpellChecker.dll mimeTools.dll NppConverter.dll NppExport.dll
Can you try removing the PluginManagerPlugins.xml from your plugin configuration directory (probably %APPDATA%\notepad++\plugins\config). Close notepad++, and then check task manager that there are no processes left called notepad++. Then open N++ again and check the plugin manager.
See also https://notepad-plus-plus.org/community/topic/12799/notepad-v7-2-1-crashes-due-to-plugin-updater-gpup-exe/10
I've been seeing the same issue for a few months. Just tried reinstalling NPP, following the steps @bruderstein posted, and reinstalling Plugin Manager (using Plugin Manager's built-in 'Reinstall' function). Still seeing this prompt regarding a non-existent update to Plugin Manager.
Notepad++ v7.3.3 (32-bit) Build time : Mar 8 2017 - 03:37:37 Path : C:\Program Files (x86)\Notepad++\notepad++.exe Admin mode : OFF Local Conf mode : OFF OS : Windows 10 (64-bit) Plugins : ComparePlugin.dll PluginManager.dll mimeTools.dll NppConverter.dll NppExport.dll
Also, I'll mention that Plugin Manager seems to be suffering from some poor/conflicting messaging which complicated trying to diagnose this issue. The NPP 'Plugin Central' page, linked from within the NPP program via the '?'>'Get More Plugins' menu item, lists 1.0.8 as the latest release of Plugin Manager. Additionally, that page links directly to this SourceForge repo, which is serving v.1.0.8 and contains no notice that it has been deprecated, or direction to find this repo which is actively maintained.
The latest update loop seems to have been caused by an erroneous update to the plugin on the admin site, that list the latest version as 1.4.4. I've just set this back, and it's fine on the development list now.
I'll force-publish the list as it will cause issues for anyone for each update.
I can't tell who or when or why this was done - the new system keeps a history :)
@bruderstein That was me. Sorry. Thought 1.4.4 might be ready for official release if no issues arise from devlist. How is version 1.4.4 involved in this issue? This kind of issues already happened with 1.4.3. Do you understand the root cause?
Only the version number was updated, not the link to the updated zip file. So plugin manager says "On, plugin Plugin Manager is at version 1.4.3, but the latest version is 1.4.4, let's install it", which it does, but it just installs 1.4.3 as that is what is downloaded.
The download loop on 1.4.3 before that change I think is the AppData thing - (#54), need to confirm that though.
I wasn't really planning on releasing 1.4.4, as it I don't think it brings anything new for the user (most of the changes I think are code cleanup) - there's some critical fixes in #55, so that will be worth releasing (feel free to review!). When we release via PM, that's a lot of users that get it automatically, so it's a lot of downloads, so I'd prefer we have an agreed plan when we say "this is now available", and when we release PM via PM.
I'm also going to take a look at #54, as I think there's some stuff broken there, so it might be worth merging these two fixes together and releasing them as one.
How about merging the fixes for #52 (in PR #55), and hopefully merging the fix for #54 then releasing that as a new release, after a few days of soak test in the dev list.
@bruderstein Are you sure? Currently https://npppm.bruderste.in/plugins/view/plugin-manager shows:
Latest version: 1.4.3
Download https://github.com/bruderstein/nppPluginManager/releases/download/v1.4.4/PluginManager_v1.4.4_UNI.zip MD5: 9b1dad977f9eb06f2c19b8b0140c8347 Copy from: plugins\PluginManager.dll To: $PLUGINDIR$\ Validate Directory Copy from: updater\gpup.exe To: $NPPDIR$\updater Validate Directory
Download via devlist worked fine for me in my tests.
See my review comment on #55.
Could you also go through my latest checkins please. There I fixed some pointer derefs. And in DirectLinkSearch.cpp backwards iterations with unsigned values with the potential of endless loops. Is DirectLinkSearch still used somewhere. In my test downloads I never got to it, just with the debugger stepping into it.
Is it possible to extend the unittest for issue #55? Would do you think.
I hadn't even seen that that had been updated too, sorry. I've put it back to 1.4.4.
But, what also needs to be done is to update the list in the old location for 1.3.5 users, and testing that that update happens correctly, otherwise people upgrade from 1.3.5 to 1.4.3, then 1.4.3 downloads the list from the new location, and notifies of an update to 1.4.4.
I would prefer if we agreed when we do this on the plugin manager - it affects a lot of users, and I'd like to be aware when things are going out, and the changes need to be worth it. And, obviously, both locations still need to be updated, as 1.3.5 is still bundled with N++.
I know there are some bug fixes in 1.4.4, but looking through them nothing major (they're very positive changes, but not things that are currently directly affecting users). The DirectLinkSearch was actually used years ago when sourceforge.net used to not provide a download link and only present an HTML page with generated link on it, so it's effectively not used any more, but there's no guarantee it wouldn't be in the future. So, it's good to have the fixes in, but I wouldn't have released them yet - we're going to have to release again with another couple of more serious fixes over the next few days.
That I wasn't aware of, that 1.3.5 still uses an older server. Thought they will get directly the 1.4.4. Probably I just tested the update from 1.4.3 -> 1.4.4.
I left some comments in the community discussion on the update loop to donho on upgrading the default version bundled with n++ to 1.4.3, but no reaction so far. Maybe the update should be then directly to the fixed version anyhow..
@dail8859 Do you known what donho thinks about updating PM? And do you know what Plugin Admin https://github.com/notepad-plus-plus/notepad-plus-plus/commit/1d59e3ed0e23b368664e5ac7330ee68826bc9608 is planned for?
Wow... Looks like Don is building it himself.
I'll drop him a mail, but if that's the case, then I wish he'd told me sooner - I've spent a lot of time preparing the new admin system etc.
Thanks all for looking into this. I see some info has been added to the outdated SourceForge repo since I checked so special thanks to whomever took care of that! Do I understand the original issue is believed to be resolved? I checked just now and was seeing the same behavior, but discovered that in fact I'm now seeing the issue https://github.com/bruderstein/nppPluginManager/issues/54 which @bruderstein referenced above. I had the NPP-packaged version of Plugin Manager still in %ProgramFiles(x86)%\Notepad++\plugins, while the update had been loaded to %APPDATA% per my configuration. I run as a non-admin user typically. The current build of Plugin Manager was being loaded at launch, and recognizing itself as up-do-date in the plugin list, but still apparently checking the un-loaded older DLL from the application directory when deciding to display this prompt. Even so, GUP.exe was prompting me for admin credentials, so I don't follow why the packaged DLL was not updated, anyway. I'm not quite sure this behavior is being addressed in the proposed change for https://github.com/bruderstein/nppPluginManager/issues/54 so I'll make a note there, as well.
@brightghost thanks for the clarification - we're going to address this AppData issue in #54. There are definitely some inconsistencies with how PM handles AppData and how N++ does it, and from your description I've been able to reproduce the behaviour that it correctly identifies that the latest is installed and running (because AppData wins), but it then says "There's an update to PM, updating is strongly recommended yada yada yada" when trying to update something.
We'll get this fixed ASAP. I'm guessing this is the update loop originally posted.
I can confirm that it still happens: Open PM, click "install" (doesn't matter if anything selected or not), get notification for new version. Install, restart Np++. Open PM, click "install", same message. Like you said.
Considered to be fixed by #56 released as v1.4.6. Also availability via the server list still needs some time.
I can confirm in my environment this is fixed by https://github.com/bruderstein/nppPluginManager/pull/56 . After reinstalling NPP with the bundled Plugin Manager and 'AppData Plugins' enabled, updating to 1.4.5 to reproduce the issue, and then manually installing build v.1.4.6 by copying the bundled files into %AppData%\Notepad++\plugins and %ProgramFiles(x86)%\Notepad++\updater, respectively, this issue is resolved.
Build v1.4.9 is available from the devlist and should finally resolve this issue.
Latest Version of Notepad++ and still have the update loop. The issue hasn't been fixed yet
@zeon2017 N++ 7.4.1 (32bit) is still bundled with PM v1.3.5 and the update is just done to version 1.4.5, but not v1.4.9. Do you observe this?
@bruderstein Hi Dave, could you please change the server list to directly update from v1.3.5 -> v1.4.9.
... This is still happening to me, as follows. Start NotePad++. Start Plugin Manager. Updates tab says installed version is 1.4.3 and available version is 1.4.9 now for Plugin Manager update. Run the install process, following prompts, NotePad++ is restarted as part of the process, etc. Start Plugin Manager again. Updates says installed version is 1.4.3 and available version is 1.4.9 again. Do it all again, with the same result. And on and on and on. Infinite loops are bad. This seems to be a bug. This seems to need a fix. IMHO. Running Window 10, fully patched and NotePad++ 7.5.4 here. Etc. HTH. Thanks. -- Mark Kamoski ...
I am too facing similar issue for a while, still it is not allowing me to install Compare Plugin required.
When I try to install compare plugin, it asks me to update Plugin Manager. Once after updating and restarting, it does the same again and again.
Please find the details below :
![image] (https://user-images.githubusercontent.com/17154535/38595262-99264502-3cff-11e8-9c0a-7046a80ef735.png)
![image] (https://user-images.githubusercontent.com/17154535/38595209-4fa771b2-3cff-11e8-9510-cc2c8377858e.png)
If you still having this issue try running Notepad++ as Administrator and go to: Plugins->Plugin Manager->Show Plugin Manager->Installed Select "Plugin Manager" and click Reinstall
Heyyy, now it is good. After having this issue for a while, left using the feature it self. Happy to see it back.
Thanks for the followup.
On Thu, May 31, 2018 at 3:54 PM, cubanfrog [email protected] wrote:
If you still having this issue try running Notepad++ as Administrator and go to: Plugins->Plugin Manager->Show Plugin Manager->Installed Select "Plugin Manager" and click Reinstall
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bruderstein/nppPluginManager/issues/45#issuecomment-393707928, or mute the thread https://github.com/notifications/unsubscribe-auth/AQXB5zAR6o9A7CuCS9_pDt4EIcCfYlKrks5t4HShgaJpZM4MVhxB .
-- Thanks, Siva.