PythonScript icon indicating copy to clipboard operation
PythonScript copied to clipboard

Console Lexer broken in Notepad 8.3.3 / Scintilla 5+

Open vinsworldcom opened this issue 2 years ago • 6 comments

The new Scintilla upgrade changes how external lexers are imported and configured. When using PythonScript 3.0.13 with Notepad 8.3.3 latest dev build, I no longer get file links in the PythonScript console:

image

Contrast this with older versions which "link" the file paths:

image

Information for updating lexers should be available in the link above.

Cheers.

vinsworldcom avatar Apr 11 '22 14:04 vinsworldcom

The same applies to PT v2.

Yaron10 avatar Apr 11 '22 19:04 Yaron10

For the styling

https://github.com/bruderstein/PythonScript/blob/651628e539c892751df3d48c7ef6f0b14604523c/PythonScript/src/ConsoleDialog.cpp#L418

needs to be adapted. And obviously all the new interfaces.

@Yaron10 PT is probably PS v2.0, or?

chcg avatar Apr 15 '22 11:04 chcg

@chcg "obviously all the new interfaces" - agree and since we both see that as "obvious", I didn't open an issue for that assuming it would come in due time. I was not aware the PythonScript console actually used a Lexer to underline the links, so thinking that was "less obvious", I opened the issue. Seems like you have it under control though!

Yes, I believe @Yaron10 means "PythonScript for Python 2.x", where I use "PythonScript for Python 3.x". They obviously are both impacted by the Scintilla upgrade.

Cheers.

vinsworldcom avatar Apr 15 '22 12:04 vinsworldcom

@chcg,

My mistake. I meant PS v2.0. Thank you for your on-going work. 👍

Yaron10 avatar Apr 16 '22 21:04 Yaron10

@chcg would it be possible to backport this defect on version v2.0.0 and release a v2.0.1 ? Thanks you

cmeriaux avatar May 20 '22 07:05 cmeriaux

would it be possible to backport this defect on version v2.0.0 and release a v2.0.1 ?

Any update on a backport? I could really use this.

alankilborn avatar Feb 04 '23 02:02 alankilborn