PythonScript icon indicating copy to clipboard operation
PythonScript copied to clipboard

Add support of double click in configuration dialog

Open cmeriaux opened this issue 4 years ago • 5 comments

To ease the configuration, add support of double click in the configuration dialog.

In the file tree-view, a double click action append to the Menu itmes the selected script

In the menu Items list and toolbar icons list, a double click action remove the selected script from this list .

cmeriaux avatar Oct 27 '20 18:10 cmeriaux

In the file tree-view, a double click action (should) append to the Menu items the selected script

This doesn't make (perfect) sense. If there was only one target location ("menu items") then yes, makes perfect sense. But since there are two possible target locations ("menu items" or "toolbar icons"), IMO it is best left as it is.

Of course, if the request is tweaked slightly for "drag and drop" support, then it is an awesome request that I support 100%. :-)

sasumner avatar Oct 27 '20 18:10 sasumner

I'm not against "drag and drop" but it's more difficult to implement.

Would you prefer to keep as it is, or add double click only on "file tree-view" and "menu items" to avoid confusion.

cmeriaux avatar Oct 27 '20 18:10 cmeriaux

Adding the double click action to remove the entries makes sense. I'm also thinking that double clicking to insert might be a little bit confusing. Drag&Drop is also nice to have but is probably much more complicated to implement. I would accept a PR on that.

chcg avatar Oct 27 '20 19:10 chcg

quick demo of the inital solution https://www.youtube.com/watch?v=JFJngDSNO-8&feature=youtu.be

I'll look at drag & drop feasibility, how I ever I doubt that it make it more effectiveness which is the aim of the feature

cmeriaux avatar Oct 27 '20 19:10 cmeriaux

Another approch would be to use multiple selection . That would be a nice solution to configure lots of scripts without pain. However, we need to use **Tree-View Control Extended Styles ** , it's only supported on windows version >= 0x0600 (See C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include\CommCtrl.rh) Is it possible to set the define _WIN32_WINNT to 0x006

image

cmeriaux avatar Oct 27 '20 21:10 cmeriaux