Bruce Guenter

Results 129 comments of Bruce Guenter

> 2. The changes in [windows/process.rs](https://github.com/GuillaumeGomez/sysinfo/pull/1044/files#diff-54c5b015ad8152587800fa45b984b4bce88054dda2afc331cf5b4bfc7c9fe2ae), in particular `total_accumulated_cpu_usage` that seems to perform a calculation of percentage of total system CPU time. Right, that confused me too, but that is...

> Could I ask again why `f32` is used to return the result instead of `u32` or `u64`? > > The source values are all integers. Floats are slow and...

> You are surely right, but what I'm after is a reference to `SystemInfo` that already contains this value (fetched via `sysconf` instead of hard-coded): [`clock_cycle: sysconf(_SC_CLK_TCK)`](https://github.com/GuillaumeGomez/sysinfo/blob/ffd95c1a84cee358f3a73411f38599357d323619/src/linux/system.rs#L102C6-L102C16) Ah, I had...

I'm seeing a bunch of tests failing on CI that I can't explain. In particular, [this test on Ubuntu](https://github.com/GuillaumeGomez/sysinfo/actions/runs/6161932429/job/16722726906?pr=1044#step:8:48) is failing now, but I haven't changed either the test or...

> The `check_processes_cpu_usage` test is flaky so you can ignore it. I suppose `check_processes_total_accumulated_cpu_usage` needs to be fixed though. ;) Agreed, I'm looking at them. > I was also surprised...

So, in the most recent commit, I added a `OnceLock` to store the global clock tick scaling data for MacOS, needed to turn the process timing values into seconds, since...

> Why not creating a struct which query this information on initialization and then keep it around? If the object is destroyed/recreated, then we re-query the information, it's fine. In...

> Hi, sorry forgot a bit about it. It seems like some test is failing on freebsd. Do you need help? Yes, I think I will. We opted to take...

I can confirm the patch I proposed causes problems for other mods. However, the patch proposed by sezero also causes artifacts on some other loops. I haven't looked further, but...

Fair questions. 1. `Arbitrary` is a trait in `proptest` that represent types that can generate "arbitrary" values of themselves. `proptest` itself is a framework for doing property testing, whereby you...