wasm-opt-rs icon indicating copy to clipboard operation
wasm-opt-rs copied to clipboard
verified publisher icon brson

Adjust upstream binaryen methods for const-correctness

Open brson opened this issue 3 years ago • 1 comments

Related to https://github.com/brson/wasm-opt-rs/issues/104. I still am unconvinced to implement that because it makes the code a bit uglier, and the patterns we are using now work for us.

We could also go upstream and make binaryen methods const-correct, which would let us use the most correct patterns in the bindings.

brson avatar Dec 07 '22 19:12 brson

Probably the thing to do is spend a small amount of time seeing how many changes are necessary to convert our bindings to be const-correct, and if that seems reasonable, file an issue upstream about it.

brson avatar Dec 08 '22 00:12 brson