electron-tabs icon indicating copy to clipboard operation
electron-tabs copied to clipboard

Fix issue with hidden second line of tabs When there are two lines

Open eddy5885 opened this issue 1 year ago • 5 comments

electron-tabs

When there are multiple lines of tabs, the second line is not visible.Because the grandfather tag of the tabs has a fixed height of 32px, the second line and onwards are hidden when there are multiple rows. Removing the fixed height and allowing the height to adapt automatically can fix this issue. Additionally, if the z-index of the content area of the web view is too high, the tabs may not be visible.

This issue can be fixed by following: #128 @da201501245

eddy5885 avatar Apr 14 '23 13:04 eddy5885

In apps, I think tabs tend to scroll sideways instead of stacking...

Example, my app that uses Electron Tabs:

https://github.com/brrd/electron-tabs/assets/51213244/86af68db-93a2-4097-aafd-d7c74c8d79ce

Example, macOS Finder:

https://github.com/brrd/electron-tabs/assets/51213244/c8c0f9ae-bb04-47cf-8ab7-abea539069c6

SudoVanilla avatar May 10 '23 02:05 SudoVanilla

@SudoVanilla you got a cool implementation. whats your app name?

eshwaruppala avatar Nov 29 '23 08:11 eshwaruppala

@eshwaruppala That app I've built with Electron Tabs is Penpot Desktop. Source code is at https://sudovanilla.com/code/Korbs/Penpot-Desktop/.

SudoVanilla avatar Nov 29 '23 08:11 SudoVanilla

@SudoVanilla Thanks for the prompt reply. I am going through the code and trying to understand how you built it. How can i theme my tabs like yours? The scrollbar is due to the fix you added using css?

Edit: I got it :)

eshwaruppala avatar Nov 29 '23 22:11 eshwaruppala

Closed this issue if it doesn't need to be opened anymore. Really, a simple CSS fix can be done by the developer.

SudoVanilla avatar Dec 08 '23 22:12 SudoVanilla