browsh
browsh copied to clipboard
browsh-org
Vertical lines through all content
I'm on Ubuntu 18.04 x64 and just installed your Ubuntu build from the website. Upon executing browsh in a gnome-terminal, I get this picture:
Not sure what's wrong, but I can't really view anything. Tried searching, and it remains like this.
Edit: exact version of browsh is the latest: 1.2.2
Oh wow, I've not seen this particular visual artefact before. Can you try a different font in the same terminal and also try another terminal. This'll just narrow down the problem, thanks.
Hmm, different fonts seem to have no effect. I tried Ubuntu Mono Regular and the default font for gnome-terminal. My firefox version is 61.0 if that helps. I tried terminator as well, but I still get the same render. What terminal do you use?
I had similar issues and it seems those can be fixed by either using a suitable terminal (i.e. Konsole) and/or the latest mosh from git.
@tobimensch right, but I don't like either of those :P Plus, I think it would be nice if this supported the default terminal in Ubuntu so that people can just try it out without having to install too many things.
@jyapayne For that to work browsh probably needs a non-true color mode. Ie.e 256 and/or 16 color mode.
For those that don't want to setup true colour, for now you can just toggle monochrome mode: ALT+m.
Although I would like to see Browsh support less colours than true colour, it's not a high priority at the moment.
@tobimensch but gnome-terminal on Ubuntu 18.04 does support true color. @tombh I just tried Konsole, and it has a similar issue for me.
@jyapayne: Compile the latest mosh from github and try with that instead of ssh.
@jyapayne I'm only ever using browsh from a remote server. I'm not sure what's causing those distortions you're seeing.
I'd really like to use this in order to have a browser in my terminal because I work mostly in vim with tmux and it gets annoying to have to switch to chrome/firefox to google things. Maybe boot up an Ubuntu VM and see if the same behavior is observed?
@Determinant @danielcb and @ghostseven: are you sure you have the same visual artefacts? Because @jyapayne has vertical lines, which is unusual. Whereas it's more typical to see horizontal lines like @crubier's screenshot above: https://github.com/browsh-org/browsh/issues/77#issuecomment-403707407 These are certainly caused by lack of true colour support.
@jyapayne I'm still at a loss as to what's causing your problem. The only thing I can think is to keep cycling through fonts and terminals. I'm using Alacritty on Arch with Ubuntu Mono and I know Source Code Pro works as well. If after trying lots of fonts and terminals you still have the same issue, then that at least is an important data point to have.
My apologies I am having the horizontal lines issue not vertical, I should have clarified this. mono mode fixed it so you are right its a true colour issue.
Also sorry that I'm seeing the horizontal lines instead of vertical ones. But interestingly, the online demo does not seem to have any problem. My terminal only supports 256 color, how can I normally use the online version without true color?
@tombh I finally found what is wrong! After deleting lines in my bashrc to see if anything changes, the offending line is this one:
export LANG="ja_JP.UTF-8"
If I remove that, everything is fine. I had it in my bashrc for some Wine configuration of Japanese applications.
@Determinant so using the same terminal (256 colours) the SSH demo looks ok, but local Browsh has horizontal lines? Browsh doesn't actually formally support anything other than true colour and monochrome mode (ALT+m). So I'm interested to hear that you're having some success with a 256 colour terminal.
@jyapayne Nice detective work! Well that's good to have in the archives here, in case someone comes across it in the future. I'll close this now then.
export LANG="en_US.UTF-8" before launching browsh
fixed the issue. my LANG is zh_CN.UTF-8 by default.
tested on vscode builtin terminal and windows terminal. works fine.
@soshimee and you've definitely confirmed that your terminal supports true colour?
https://gist.github.com/XVilka/8346728
Yes, I tried the code, and I see smooth rainbow. I'm using Konsole to be specific.
oh that's really interesting. and have you tried different fonts. if you could add a screenshot, it could help others too
It does disappear after scrolling, but letters become even more scrambled.