browserpass-extension
browserpass-extension copied to clipboard
Replace Store Color Select Box in Add View
The addEditInterface.js should use store color settings.
Okay, just an FYI, I couldn't get the `hover/focused` option to keep it's store colors due to it not being consistent across browsers or just not avail. Some suggest implementing one's own drop down + options, which shouldn't be do bad just in mirthil. I just didn't want to do that in this PR.
Originally posted by @patgmiller in https://github.com/browserpass/browserpass-extension/pull/290#discussion_r984160389
Applying hover / focused color + styles to plain old built-in select:options is not consistent across browsers nor fully supported either. It will be simpler and better to implement a custom select / drop down with mithril or use an existing library if it not too bloated since we're only trying to add color, hover, etc to an html element.
It will be simpler and better to implement a custom select / drop down with mithril or use an existing library...
My preference would be to implement it ourselves, given it should be fairly straightforward. Given that we handle sensitive info, I'd prefer not to import too many dependencies.
Okay, makes sense. After all that's why I used the Object.prototype for the models stuff and to avoid extra bloat.