browserpass-extension icon indicating copy to clipboard operation
browserpass-extension copied to clipboard

Published 20 hours ago • verified publisher icon browserpass

Honor store-specific enableOTP setting

Open shinenelson opened this issue 3 years ago • 2 comments

The Options allow for the enableOTP feature to be specified within the .browserpass.json, but the feature is not enabled when the option is specified within .browserpass.json and not globally.

This was because the check for the setting was only looking for the global setting - settings.enableOTP and did not check for the .browserpass.json setting ( settings.stores[*].settings.enableOTP ).

This changeset fixes that issue and properly honors the enableOTP setting specified within .browserpass.json with or without the global enableOTP setting.

shinenelson avatar Apr 09 '21 17:04 shinenelson

Ping @erayd if the review request was missed

shinenelson avatar Apr 23 '21 22:04 shinenelson

Ping @erayd if the review request was missed

Not missed, just short on time. I'm expecting to have some time to spend working on Browserpass during the coming week, which will include this PR.

erayd avatar Apr 24 '21 04:04 erayd