browserpass-extension icon indicating copy to clipboard operation
browserpass-extension copied to clipboard

Allow hiding badge counter

Open max-baz opened this issue 5 years ago • 4 comments

Note this implementation doesn't just prevent entering updateMatchingPasswordsCount() function (as I personally initially expected), but only prevents doing what is hopefully the most expensive computation: getting a huge array of files and processing them.

This way, when a user toggles badge option we would refresh the badge instantly, and also if a user puts hideBadge in their .browserpass.json we would detect it within a minute. This also means that tab update handler still executes and it still refreshes settings every minute.

I would be really interested to know if this solves #224, @elprans if you could try this PR it would be much appreciated.

@erayd what do you think in general?

Fixes #224 Fixes #103 Fixes #342 Fixes #348

max-baz avatar Sep 09 '20 22:09 max-baz

@maximbaz Do you need me to do performance testing on this, or have you verified that bit already and just need code review?

erayd avatar Sep 11 '20 06:09 erayd

Performance test would be appreciated, no I don't know for sure that it solves #224

max-baz avatar Sep 11 '20 06:09 max-baz

Sweet, I'll test that aspect first then.

erayd avatar Sep 11 '20 06:09 erayd

This is very requested feature recently, and multiple people have tested this PR. I've just rebased it on latest master. I think it makes sense to merge it, @erayd would you like to review this before then?

max-baz avatar Apr 16 '24 16:04 max-baz