browserpass-extension icon indicating copy to clipboard operation
browserpass-extension copied to clipboard

Improve search performance

Open jplitza opened this issue 6 years ago • 0 comments

General information

  • Operating system + version: Ubuntu 18.04
  • Browser + version: Firefox 70
  • Information about the host app:
    • How did you install it? Prebuilt binary IIRC
    • If installed an official release, put a version ($ browserpass --version): Browserpass host app version: 3.0.6
    • If built from sources, put a commit id ($ git describe --always):
  • Information about the browser extension:
    • How did you install it? Downloaded from addons.mozilla.org
    • Browserpass extension version as reported by your browser: 3.4.1

Exact steps to reproduce the problem

  1. Create a password store with over a thousand files in many nested directories. Randomized example that you can use:

    mkdir .password-store
    cd .password-store
    curl -L 'https://github.com/browserpass/browserpass-extension/files/3843126/find.txt' | while read f; do mkdir -p $(dirname "$f") && touch "$f"; done
    
  2. Use the search

What should happen?

It's amazingly fast! :sparkles:

small password store cut

What happened instead?

It takes over a second to initially load, and removing the domain filter as well as the first keypresses of the incremental search over all items takes ages.

large password store cut

jplitza avatar Nov 13 '19 19:11 jplitza