students icon indicating copy to clipboard operation
students copied to clipboard

Binarize QE models and make tool to do that

Open kpu opened this issue 3 years ago • 1 comments

@mfomicheva e-mailed some JSON files which I have now checked in: https://github.com/browsermt/students/commit/962d419729ff5145b2ba30be182c1e90991ca7a4

As @mfomicheva wrote in a follow up, these need to be binarized. The documentation refers to this thing:

https://github.com/abarbosa94/bergamot-translator/blob/quality-estimator-update/src/tests/units/quality_estimator_tests.cpp#L43

Can we get a proper tool for that? It doesn't have to be a full-on JSON parsing thing, but the values shouldn't be hard-coded in the C++. Binarized models are more important though.

kpu avatar Jan 27 '22 14:01 kpu

@mfomicheva Thanks for the repo https://github.com/browsermt/quality-estimation with QE training and soon the binarizer.

@felipesantosk @mfomicheva Can you binarize the 3 JSON files and submit a PR to this repo (students) with the binary files? (One of them is done already.)

kpu avatar Feb 17 '22 13:02 kpu