http-browserify icon indicating copy to clipboard operation
http-browserify copied to clipboard

Published 20 hours ago • verified publisher icon browserify

`ClientRequest#setTimeout` Support

Open pvoisin opened this issue 10 years ago • 5 comments

First time I'm using Browserify, first test, and I stumble on that... ;)

It currently doesn't seem to support setTimeout.

pvoisin avatar May 01 '14 19:05 pvoisin

Is there any interest in pulling in a fix for this, if write a pull request? I've ran into a situation where the lack of setTimeout is breaking some libraries when they are Browserified. The maintainer of one library in particular would prefer an upstream fix and I'm willing to write it if there's interest.

brandonrobertz avatar Jan 17 '15 19:01 brandonrobertz

+1, would appreciate a fix for this as well

dcousens avatar Jan 21 '15 03:01 dcousens

Just an update, I'm working on this and should have a PR for this issue this weekend.

brandonrobertz avatar Jan 23 '15 22:01 brandonrobertz

Initial push on this. It's still just in my fork. I've verified that it works with my target library (https://github.com/freewil/node-bitcoin). Anyone else want to take a look?

https://github.com/brandonrobertz/http-browserify/compare/substack:master...master

brandonrobertz avatar Jan 25 '15 19:01 brandonrobertz

https://github.com/substack/http-browserify/pull/80

brandonrobertz avatar Jan 27 '15 02:01 brandonrobertz