http-browserify icon indicating copy to clipboard operation
http-browserify copied to clipboard

Don't `require('buffer')`

Open tellnes opened this issue 12 years ago • 3 comments

The buffer implementation is a lot of code and http-browserify does not really need it to work. It is only needed for auth parameter to bas64 encode it.

Could it be document that the auth parameter is not supported or changed to depend on a base64 library or? Eg. base64-js which buffer-browserify depends on.

tellnes avatar Aug 08 '13 23:08 tellnes

Where do you see require('buffer')? It looks like buffer is not directly required by http-browserify but rather by stream, which is needed to make the request and response objects be streams. Streams operate on Buffers, so it's required.

feross avatar Dec 05 '13 02:12 feross

When I filled this was buffer directly required by http-browserify. Probably did someone resolve it and now, it has been reintroduced by stream.

tellnes avatar Sep 09 '14 10:09 tellnes

This issue should be closed.

feross avatar Jul 08 '15 16:07 feross