http-browserify icon indicating copy to clipboard operation
http-browserify copied to clipboard

add Response#setEncoding

Open tellnes opened this issue 12 years ago • 8 comments

tellnes avatar Aug 05 '12 13:08 tellnes

+1

Jxck avatar Sep 09 '14 10:09 Jxck

+1

acgray avatar Sep 16 '14 09:09 acgray

better than nothing +1

kumavis avatar Jan 18 '15 06:01 kumavis

+1

guasek avatar Jan 18 '15 09:01 guasek

I'll rebase this if one with commit bit says it will be merged.

tellnes avatar Jan 29 '15 13:01 tellnes

+1

shergin avatar Jun 07 '15 18:06 shergin

+3

saiichihashimoto avatar Jun 10 '15 06:06 saiichihashimoto

One can at least put the following code into lib/response.js, to make the error disappear:

Response.prototype.setEncoding = function(encoding) { // not implemented }

If needed, you have to handle the encoding elsewhere, because that would need further changes in http-browserify.

patrickmetz avatar Jul 21 '21 18:07 patrickmetz