crypto-browserify icon indicating copy to clipboard operation
crypto-browserify copied to clipboard

Published 20 hours ago • verified publisher icon browserify

feat: implement getRandomValues and randomUUID - resolves #213 and #214

Open markhughes opened this issue 2 years ago • 15 comments

This implements https://github.com/crypto-browserify/crypto-browserify/issues/213 and https://github.com/crypto-browserify/crypto-browserify/issues/214

markhughes avatar May 04 '22 06:05 markhughes

Any update on getting this merged or looked at?

Gambitboy avatar May 20 '22 05:05 Gambitboy

Any updates? This is important so we can try replace react-native-crypto by crypto-browserify.

brunomacf avatar Jun 22 '22 15:06 brunomacf

unsure about the status of crypto-browserify, I think the project is not maintained TBH. Happy to help maintain if current maintainers are inactive?

markhughes avatar Jun 23 '22 03:06 markhughes

@markhughes do you want to maintain a fork? I will be one of many who are interested to use.

3cp avatar Jun 30 '22 23:06 3cp

@jprichardson , @calvinmetcalf , @ForbesLindesay or @fanatid any assistance?

Gambitboy avatar Jul 01 '22 09:07 Gambitboy

Hi, two things:

  • can you move tape update to another PR?
  • is it possible to leave links to node source code for verification that everything is the same?

Thanks!

fanatid avatar Jul 03 '22 05:07 fanatid

Just stopping by to say I would also be eager to see getRandomValues implemented in this library! Thanks @markhughes!

eggplantzzz avatar Jul 14 '22 14:07 eggplantzzz

Sorry I will fix this PR up later this week, I've been sick and in-out of hospital

markhughes avatar Aug 01 '22 21:08 markhughes

Hello @markhughes , any updates on adding randomUUID() to crypto-browserify?

shmillar avatar Feb 13 '23 19:02 shmillar

Also curious about when (if 😅) this will be merged in

BenGu3 avatar Feb 17 '23 23:02 BenGu3

Hi @fanatid sorry for the delay I've been dealing with some health issues!

can you move tape update to another PR?

Got it out of here, thanks. Not sure how that one snuck in but it was required to run on my computer.

is it possible to leave links to node source code for verification that everything is the same?

Perhaps just the specs?

  • https://w3c.github.io/webcrypto/#Crypto-method-getRandomValues
  • https://w3c.github.io/webcrypto/#Crypto-method-randomUUID

Edit: which matches

  • https://nodejs.org/api/webcrypto.html#cryptogetrandomvaluestypedarray
  • https://nodejs.org/api/webcrypto.html#cryptorandomuuid

markhughes avatar Feb 20 '23 21:02 markhughes

Hey @fanatid, @jprichardson, @calvinmetcalf, @ForbesLindesay, @dcousens - you seem like the more recent past contributors in the browserify package. Could we possibly look at this?

markhughes avatar Jul 19 '23 22:07 markhughes

Any updates? Is there an alternative package anyone is using?

CC: @markhughes @dcousens

jhenriquez avatar Sep 27 '23 18:09 jhenriquez

It just needs to be merged. I'm using it for my own projects, but I don't think browserify is maintained like it used to be

markhughes avatar Oct 07 '23 01:10 markhughes

Thank you @markhughes, doesn’t seem that anyone is maintaining the library. We forked yours so we can use it indefinitely.

Hopefully someone will take over maintenance here. This library is a recommended webpack 5 polyfill.

jhenriquez-ax avatar Oct 07 '23 02:10 jhenriquez-ax