crypto-browserify
crypto-browserify copied to clipboard
browserify
Added generateKeyPair
@lmarianski could you add a test that makes sure that the outputs of this are valid inputs
Oh yeah i forgot about this, i'll try to put something together, any ideas on what would the test actually entail? (besides the actual key generation, to make sure all is working)
Also, any ideas as to why it's freaking out about the template string I use in my package?
Anyways, added some tests, hope those will do, let me know if I should add anything else, and btw the whole test suite does pass for me locally (maybe its due to the travis script using older nodejs versions?)
we need to bump the node version in the .travis file, maybe to 10 or 12, I forget which is currently stable
On Fri, Jul 31, 2020 at 3:48 PM Łukasz Mariański [email protected] wrote:
Anyways, added some tests, hope those will do, let me know if I should add anything else, and btw the whole test suite does pass for me locally
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/crypto-browserify/crypto-browserify/pull/186#issuecomment-667321068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAITRH6H4N5PFYXTZMD4X63R6MNYDANCNFSM4IKCS5HQ .
-- -Calvin W. Metcalf
actually @lmarianski you need to avoid requring crypto and instead require the specific libraries you need, what you need to do here is make 2 versions, one for node one for the browser and have a switch in the package.json
