common-shakeify

common-shakeify copied to clipboard

v1.1 has a bug compared to v0 and v1.0: require can't take a number

3

I get this error output in my tests: ``` node:internal/validators:114 throw new ERR_INVALID_ARG_TYPE(name, 'string', value); ^ TypeError [ERR_INVALID_ARG_TYPE]: The "id" argument must be of type string. Received type number (298)...

ljharb

Just upgraded the dependencies in an old project and tried re-running the browserify portion. common-shakeify v1.1.1 Node 16.16.0 OSX Arm ```javascript b = browserify(options).plugin(commonShakeify, {}); b.transform('babelify', { presets: ['@babel/preset-env'], sourceMaps:...

scottlet

hello and thank you for all your great open source work! 👋 here's a simplified repro case for an error i'm running into in the wild. ```js // foo.js const...

jgravois

This plugin fails to shake Apollo Client leading to an immensely bloated bundle. Apollo Client provides a CommonJS bundle, which allegedly is targeted for Node, but I can't see anything...

tornqvist

What is the "Could not redupe module ..." actually mean?

3

I received an error: ``` browserify : Could not redupe module /path/to/scada.js/node_modules/moment/moment.js ``` What does it mean? What should I do?

ceremcem

In verbose mode, the call to `path.relative` throws an error when `--full-paths` flag is _not_ used. This is because the module name will be a number. https://github.com/browserify/common-shakeify/blob/master/index.js#L30 Example: ``` $...

jeremija

Does not shake off other modules when importing with default

1

This plugin works great but unfortunately it does not allow to import `default` exports only. Steps to reproduce: 1. Checkout https://github.com/Sobesednik/bs-sh on github 1. `git clone https://github.com/Sobesednik/bs-sh.git` 1. `cd bs-sh`...

z-vr

does not remove imports that belongs to dead code which is removed by common-shake

1

Thanks for the efforts. This plugin works great. I will try to explain the case i came across. "index.es6" imports {Storage} from "abc" which intern import {Cookie} from "xyz". "abc"...

nikhildpawar

shakes out functions that I used

6

I'm not sure if this plugin in production ready yet, but it seems that it removed functions that I'm definitely using. Using import to get the modules, but running babel...

Zae

otherwise this does nothing and you dont realise

goto-bus-stop