browser-pack icon indicating copy to clipboard operation
browser-pack copied to clipboard

expose module.parent as in node

Open dominictarr opened this issue 11 years ago • 7 comments

This pr resolves https://github.com/substack/node-browserify/issues/976 It only makes the prelude 23 bytes longer, this will help more node modules work in the browser by default.

dominictarr avatar Nov 07 '14 14:11 dominictarr

bump

dominictarr avatar Aug 05 '15 14:08 dominictarr

really this should be merged because it makes browserify more consistent with node.

dominictarr avatar Aug 05 '15 14:08 dominictarr

@dominictarr can you update this PR to point at another branch?

terinjokes avatar Jun 08 '16 17:06 terinjokes

@terinjokes not sure I follow, do you want me to update this merge cleanly with current master? which branch?

dominictarr avatar Jun 08 '16 23:06 dominictarr

@dominictarr I'm sorry, I was unclear. This PR points at your fork's master branch, which you've since pushed changes to rename it to nodepack.

Without those changes, this looks to apply cleanly. I don't mind cherrypicking, so not too much of a problem.

terinjokes avatar Jun 08 '16 23:06 terinjokes

oh, I see, sorry about that. I'll fix this.

dominictarr avatar Jun 09 '16 04:06 dominictarr

okay I refactored to this branch https://github.com/dominictarr/nodepack/tree/parent but turns out browser-pack has changed a lot since I did this so it' doesn't merge anymore (i tried but tests break)

dominictarr avatar Jun 09 '16 04:06 dominictarr