code.pyret.org icon indicating copy to clipboard operation
code.pyret.org copied to clipboard

Published 20 hours ago • verified publisher icon brownplt

[WIP] Share modal updates

Open asolove opened this issue 2 years ago • 5 comments

  • [X] #492: fix wording of text
  • [ ] #493: import snippet should be less visible than share url.
  • [ ] Show currently published-version v current version

asolove avatar Nov 07 '23 12:11 asolove

@asolove any chance we can close this out in the near future? It's super low-hanging fruit..

schanzer avatar Jan 11 '24 17:01 schanzer

Happy to. Can you review the open questions and venture some opinions? I’ll have to load it back into my head but there isn’t much left here as I recall.

On Thu, Jan 11, 2024 at 12:13 PM Emmanuel Schanzer @.***> wrote:

@asolove https://github.com/asolove any chance we can close this out in the near future? It's super low-hanging fruit..

— Reply to this email directly, view it on GitHub https://github.com/brownplt/code.pyret.org/pull/494#issuecomment-1887604424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACCL6EJY7SXBRXQHSJPJLYOAMSLAVCNFSM6AAAAAA7BDAT2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBXGYYDINBSGQ . You are receiving this because you were mentioned.Message ID: @.***>

asolove avatar Jan 11 '24 17:01 asolove

Excuse my ignorance here - where are these questions?

schanzer avatar Jan 11 '24 17:01 schanzer

Oh, sorry, there is a long discussion in another issue around further updates to the share sheet. But yeah, this small round of tweaks can just get merged shortly.

asolove avatar Jan 13 '24 18:01 asolove

Does this PR address all three checkboxes, above? Or just the one? If it's just one I think it's best to wait until we snag the others.

schanzer avatar Jan 15 '24 01:01 schanzer