code.pyret.org icon indicating copy to clipboard operation
code.pyret.org copied to clipboard

Published 20 hours ago • verified publisher icon brownplt

Josh/nolan localfilesave

Open j3ven7 opened this issue 6 years ago • 6 comments

First merge

j3ven7 avatar Feb 11 '19 16:02 j3ven7

@blerner I'm assuming that

  1. CPO has changed enough in the last half-decade that this PR is no longer usable, and
  2. That with Anchor coming down the pike, this will also soon be moot.

OK to close?

schanzer avatar Mar 12 '24 14:03 schanzer

I've never seen this code before. I don't know what it is intended to do...

blerner avatar Mar 12 '24 14:03 blerner

This was a great idea at the time. It will be superseded by other save-to-localstorage/indexedDB solutions before we can make use of it, though.

jpolitz avatar Mar 12 '24 16:03 jpolitz

(This was actually really great work that went a little beyond just local file saving. It was an electron-hosted container for CPO for offline use.)

jpolitz avatar Mar 12 '24 16:03 jpolitz

Well that does sound cool! 👍

blerner avatar Mar 12 '24 16:03 blerner

Actually now I'm realizing it still has some good ideas. Looking at the diff is probably useful, and actually only package* conflict. It's kind of orthogonal to what's going on on the page. And since we have BrowserFS presumably we can swap in real node implementations of that API. Not a totally outlandish experiment to try and finish.

jpolitz avatar Mar 12 '24 17:03 jpolitz