code.pyret.org
code.pyret.org copied to clipboard
brownplt
Include seen to not work, and screw up identification of REPL entries
Not so fast, @jpolitz. The last major commits to either pyret-lang or code.pyret.org were seven days ago; this issue was filed five days ago.
I'm not sure that this is just a highlighting issue, too. The types of errors @blerner and you encountered are completely different (unbound-id and arity-mismatch, respectively).
There is still a strictly highlighting issue in your screenshot @jpolitz. I can't replicate @blerner's error, so I'll tackle the issue of "operator" having too-wide of a highlight.
Can we make the issue more specific? The original screenshot isn't causing an error any more, and "bad highlights" can refer to a zillion different things.
My hunch is there are two problems that caused my original issue, but I can't track either of them down. One is, sometimes hitting the run button or pressing enter in the repl doesn't "take", and there's some kind of race between when the buttons get activated and when Pyret really starts running. The other is sometimes the error message highlights on repl entries get confused which entry to point to. I've seen both things happen, and collectively that explains my original screenshot: the include didn't work, and the highlight went to the wrong entry.
I confirm what Ben said about "race between when the buttons get activated and when Pyret really starts running". Pretty much, we need to wait until "REPL is ready" appears in the js console before hitting run or using REPL. Otherwise, it results in a silent error. I encounter this bug every time I do plot library development -- very often that I get used to it, but it would be pretty rare for most users since no one is going to use the REPL or hit the run button that fast.
Is this still a race condition, or have we fixed this sometime in the past year?
As far as I can tell, the race condition problem is gone. The Run button is only clickable after "REPL is ready" appears. Similarly, the REPL is blocked by the rotating lambda until "REPL is ready" appears.