code.pyret.org
code.pyret.org copied to clipboard
brownplt
Table rendering in REPL does not have high enough contrast.
@ds26gte this could be a good accessibility issue, too. Possibly add a high-contrast color mode? Not sure how to trigger it (key, menu, mouse, other?) But it might be a useful thing for teachers, too...
If it doesn’t work for sighted users in classrooms, this feels more like a usability issue than an accessibility one.
If our default CSS fails to work in this setting, it means we need better CSS
It works well locally on an individual user's computer. (Having a sharper contrast in rows would obscure the values a bit more that we'd like.) But projector screens usually have horrible contrast. For the same reason we have font size adjustments for teachers, we might want a color theme toggle, too. And sighted users with some vision impairment might also appreciate a different color scheme.
You’re going to hate me for saying this, but all I can say is “we should hold ourselves to a higher standard.” We could alternate shadings between odd and even number rows. We could use wider borders, darker borders, or whatever — either way, I just can’t believe we can’t come up with something that works for projectors.
Nonsequitur. We do alternate shading on each row, and we do have borders. Etc. What we want to avoid is that the backgrounds of the rows obscure the contents of the rows, especially when the rows contain images with arbitrary background colors themselves... So we're limited in what palettes we can use.
Imho, this is the same as the problem that PowerPoint color schemes look good on either your own screen or the projector screen, but almost never both :-\ I think it's probably a good idea to consider having two separate color schemes, as a result.
We alternate them already? Wow, it's barely visible on my own monitor (an admittedly-old Apple 27" cinema display). The fact that I didn't realize this until now suggests that our current solution may not be as good as it could be.
I hear you on not wanting to hide the contents of the table, but as long as we have alternating rows, we run the risk of obscuring the table contents for two specific shades. Making one of those shades darker doesn't increase that risk, does it?
I think our use-case is far simpler than PPTs, and that we should be able to do a better job here. Why not have the even rows just be slightly darker? Some simple experimenting in the Web Inspector gets the attached screenshot, and all I had to do was darken the even rows a few shades. While I was at it, I also made the header row much darker and more visually-distinct from data rows, which I think we need anyway.
FYI, if you like the screenshot above, this is just two CSS file changes:
editor.css line 1690: #e2e2e2 editor.css line 1664: #666