Andrew Gene Brown

With recent work on fetchNASIS (https://github.com/ncss-tech/soilDB/commit/0b3d5177382f79c4c6a68538905a50e702ef848c) `.formatcoParentMaterialString` has been deprecated in favor of `.formatParentMaterialString` for component data.

Great! and a good reminder to put this in my profile: https://orcid.org/0000-0002-4565-533X. I would be happy to weigh in more as needed down the line. I am interested in learning...

A note to extend methods where possible so that they can work with other data sources e.g. SCAN, CDEC

Looks like we will also need to change the usage of `base::as.POSIXct()` `format` argument in `soilDB:::.fill_missing_days()` as it is breaking with R devel. ``` ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error...

> I'll try to take a look next week sometime, unless you have time before then. Take a look at this issue as a whole? I can probably take a...

Can you provide a sample dataset / query / function call where this is an issue? The current version of `uncode()` should not require ChoiceName == ChoiceLabel, in general. That...

I think this _mostly_ works... but I see what you mean about if you `code()` a `ChoiceLabel` and then `uncode()` those coded values, you get `ChoiceName`. ``` r library(soilDB) x...

I think you are right that the logic should be simplified at least for the `invert=FALSE` case... and as you show there is an issue when combining two different sets...

This issue also alerted me to a problem with some of the new functions to help with explicitly setting factor levels. Again the overlap between ChoiceName and ChoiceLabel causes issues,...

Thanks for reporting this. I would be happy to work with you 1:1 to sort this out, but please first check out the following ideas I have. > The most...