Andrew Gene Brown

Results 162 comments of Andrew Gene Brown

> Did you want this in 2.0? If it is finished in time then it would be fine to include it, but I wouldn't say it is necessary to include....

In many cases `estimateAWC()` gives values similar to those expected by NASIS validations on aggregate component data. The validation "allowed ranges" are calculated from the (_usually_ also calculated) water retention...

stub ideas ### comparison of NEON sampling locations v.s. SSURGO - SSURGO/STATSGO -- component, taxonomic, interpretative concepts - `tauW` - web coverage service (numeric comparison w/ 800m properties or class...

OK, I took a look at number 3 in your list and found 3 more things that need addressing. - [ ] cannot segment a single profile if the interval...

I wanted to use segment for an example I was working on -- and I came up with this example which is a more concise demo of the phenomenon I...

> I'm not sure if `glom(..., fill = TRUE)` is working as expected (dropped profiles?). You are right, that is a bug in the case where no profiles have horizons...

I intend to open a PR linked to this issue with my suggestions and comments in it. I feel this will be easier to provide specific feedback on instances/lines of...

Good work on fixing it up for this release though #179

Tagging @smroecker @jskovlin in particular for thoughts on this. I didn't seek enough feedback prior to implementing this change so I'd like to at least fix it in a way...

I was thinking about this some more and was wondering if this could be an opportunity to generalize `diagnostic_hz` as well as `restrictions`. We could define a SPC method such...